Re-exports crates for which local traits are implemented #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
reviewed
Oct 13, 2023
| pub use imbl; | ||
| #[cfg(all(feature = "rpds", feature = "archery"))] | ||
| pub use rpds; | ||
|
|
There was a problem hiding this comment.
I feel like these should all be wrapped in a pub mod reexports or they will be in the root. Actually it might not be that bad since most people will only enable one or a few of these anyway.
Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to access the exact crates for which
ShaderTypeis implemented when using optional features like e.g.nalgebraortinyvec. This is done like so:encase::nalgebra::...Without this PR, consumers of this crate must look into encase's Cargo.lock file and add exactly the same version of encase's dependency to their own Cargo.toml file.
closes #51